lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Feb 2014 13:56:16 -0800 From: Christoph Hellwig <hch@...radead.org> To: Dave Chinner <david@...morbit.com> Cc: Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org, xfs@....sgi.com, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 5/6] xfstests: Define fallocate flags locally in fsx On Wed, Feb 26, 2014 at 07:39:22AM +1100, Dave Chinner wrote: > > index b3c30db..331257e 100644 > > --- a/ltp/fsx.c > > +++ b/ltp/fsx.c > > @@ -35,8 +35,13 @@ > > #endif > > #ifdef FALLOCATE > > #include <linux/falloc.h> > > +#ifndef FALLOC_FL_PUNCH_HOLE > > +#define FALLOC_FL_PUNCH_HOLE 0x02 /* de-allocates range */ > > +#endif > > +#ifndef FALLOC_FL_ZERO_RANGE > > +#define FALLOC_FL_ZERO_RANGE 0x10 /* zeroes range */ > > +#endif > > #endif > > This pattern is appearing all over the place in xfstests now. I'd > suggest that this should really be handled by autoconf, > include/config.h and src/globals.h.... Can we handle this nicely using autoconf, especially in the case of O_ flags that might be different for different architectures? Either way having a single header for the various flags that might not be present in the system headers sounds like a good plan. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists