linux-ext4 - Re: [patch] ext3: remove an unneeded check in ext3_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140225094929.GA1669@quack.suse.cz>
Date:	Tue, 25 Feb 2014 10:49:29 +0100
From:	Jan Kara <jack@...e.cz>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ext3: remove an unneeded check in ext3_new_blocks()

On Tue 25-02-14 11:39:45, Dan Carpenter wrote:
> We know "fatal" is zero here.  The code can be simplified a bit by
> assigning directly.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
  Thanks. Added to my tree.

								Honza

> 
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 22548f56197b..158b5d4ce067 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1727,10 +1727,7 @@ allocated:
>  	percpu_counter_sub(&sbi->s_freeblocks_counter, num);
>  
>  	BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
> -	err = ext3_journal_dirty_metadata(handle, gdp_bh);
> -	if (!fatal)
> -		fatal = err;
> -
> +	fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
>  	if (fatal)
>  		goto out;
>  
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html