linux-ext4 - Re: [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd-ngheH2njza1Tq0umONrF+VBrmB+9SiVG1Q=DsM0PBBA@mail.gmail.com>
Date:	Thu, 27 Feb 2014 12:59:51 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Dongsu Park <dongsu.park@...fitbricks.com>,
	Karel Zak <kzak@...hat.com>
Cc:	linux-fsdevel@...r.kernel.org, xfs@....sgi.com,
	linux-ext4@...r.kernel.org, tytso@....edu,
	Lukas Czerner <lczerner@...hat.com>,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ashish Sangwan <a.sangwan@...sung.com>
Subject: Re: [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE

Hi Dongsu.
> As discussed in the thread "[PATCH RESEND 3/10] ext4: Add support
> FALLOC_FL_COLLAPSE_RANGE for fallocate", [3] this patch to util-linux
> will be useful for testing collapse-range inside xfstests.
As Dave pointed, this patch is needed for fsstress not xfstests.
>
> [1] https://lkml.org/lkml/2014/2/18/374
> [2] https://lkml.org/lkml/2014/2/20/318
> [3] https://lkml.org/lkml/2014/2/18/83
>
> @@ -51,6 +52,10 @@
>  # define FALLOC_FL_PUNCH_HOLE 2
>  #endif
>
> +#ifndef FALLOC_FL_COLLAPSE_RANGE
> +# define FALLOC_FL_COLLAPSE_RANGE 8
> +#endif
> +
>  #include "nls.h"
>  #include "strutils.h"
>  #include "c.h"
> @@ -66,12 +71,13 @@ static void __attribute__((__noreturn__)) usage(FILE
> *out)
>  	fprintf(out,
>  	      _(" %s [options] <filename>\n"), program_invocation_short_name);
>  	fputs(USAGE_OPTIONS, out);
> -	fputs(_(" -d, --dig-holes     detect and dig holes\n"), out);
> -	fputs(_(" -l, --length <num>  length of the (de)allocation, in bytes\n"),
> out);
> -	fputs(_(" -n, --keep-size     don't modify the length of the file\n"),
> out);
> -	fputs(_(" -o, --offset <num>  offset of the (de)allocation, in bytes\n"),
> out);
> -	fputs(_(" -p, --punch-hole    punch holes in the file\n"), out);
> -	fputs(_(" -v, --verbose       verbose mode\n"), out);
> +	fputs(_(" -c, --collapse-range collapse a hole in the file\n"), out);
I think that it is better to change like this => "collapse space in the file"
And I add util-liunx's maintainer in this mail loop.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html