linux-ext4 - Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Feb 2014 16:01:50 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	xfs@....sgi.com
Subject: Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate

On Tue, Feb 25, 2014 at 08:15:33PM +0100, Lukas Czerner wrote:
> Add fzero command which zeroes a range of the file using
> fallocate FALLOC_FL_ZERO_RANGE flag.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Looks ok, but...

> @@ -312,7 +342,17 @@ prealloc_init(void)
>  	fcollapse_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>  	fcollapse_cmd.args = _("off len");
>  	fcollapse_cmd.oneline =
> -	_("de-allocates space and eliminates the hole by shifting extents");
> +		_("de-allocates space and eliminates the hole by shifting extents");
>  	add_command(&fcollapse_cmd);

I'll drop this change because it pushes the line beyond 80
characters....

Otherwise,

Reviewed-by: Dave Chinner <dchinner@...hat.com>

-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html