linux-ext4 - Re: [PATCH] ext3/4: remove some unnecessary comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <530FF88B.5060709@huawei.com>
Date:	Fri, 28 Feb 2014 10:46:35 +0800
From:	ZhangZhen <zhenzhang.zhang@...wei.com>
To:	Lukáš Czerner <lczerner@...hat.com>
CC:	Li Zefan <lizefan@...wei.com>, <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext3/4: remove some unnecessary comments

On 2014/2/27 19:44, Lukáš Czerner wrote:
> On Thu, 27 Feb 2014, ZhangZhen wrote:
> 
>> Date: Thu, 27 Feb 2014 17:26:09 +0800
>> From: ZhangZhen <zhenzhang.zhang@...wei.com>
>> To: jack@...e.cz, tytso@....edu
>> Cc: linux-ext4@...r.kernel.org
>> Subject: [PATCH] ext3/4: remove some unnecessary comments
>>
>> The comments in the code are unnecessary, because every generic_file_write()
>> is replaced by generic_file_aio_write().
> 
> I am sorry I do not understand. Is it unnecessary or wrong ? If it's
> wrong why it is wrong ?
> 
> Your description suggests that this should be changed to mention
> generic_file_aio_write() rather than generic_file_write().
> 
> Thanks!
> -Lukas
> 
Thanks for reviewing!

Here should be changed to mention generic_file_aio_write() rather than
generic_file_write().

I will modify this patch for V2.
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@...wei.com>
>> ---
>>  fs/ext3/inode.c | 4 ----
>>  fs/ext4/inode.c | 4 ----
>>  2 files changed, 8 deletions(-)
>>
>> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
>> index 384b6eb..e08c2eb 100644
>> --- a/fs/ext3/inode.c
>> +++ b/fs/ext3/inode.c
>> @@ -3212,10 +3212,6 @@ out_brelse:
>>   *
>>   * We are called from a few places:
>>   *
>> - * - Within generic_file_write() for O_SYNC files.
>> - *   Here, there will be no transaction running. We wait for any running
>> - *   transaction to commit.
>> - *
>>   * - Within sys_sync(), kupdate and such.
>>   *   We wait on commit, if tol to.
>>   *
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index 6e39895..5ef32f0 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -4399,10 +4399,6 @@ out_brelse:
>>   *
>>   * We are called from a few places:
>>   *
>> - * - Within generic_file_write() for O_SYNC files.
>> - *   Here, there will be no transaction running. We wait for any running
>> - *   transaction to commit.
>> - *
>>   * - Within sys_sync(), kupdate and such.
>>   *   We wait on commit, if tol to.
>>   *
>>
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html