linux-ext4 - Re: [PATCH] ext3: fix some wrong comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2014 09:44:02 +0800
From:	ZhangZhen <zhenzhang.zhang@...wei.com>
To:	Jan Kara <jack@...e.cz>
CC:	<linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext3: fix some wrong comments

On 2014/2/28 16:37, Jan Kara wrote:
> On Fri 28-02-14 15:28:59, ZhangZhen wrote:
>> The comments in the code are wrong, because every generic_file_write()
>> is replaced by generic_file_aio_write().
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@...wei.com>
>> ---
>>  fs/ext3/inode.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
>> index 384b6eb..0b94832 100644
>> --- a/fs/ext3/inode.c
>> +++ b/fs/ext3/inode.c
>> @@ -1574,7 +1574,7 @@ static int buffer_unmapped(handle_t *handle, struct buffer_head *bh)
>>   *
>>   * Similar for:
>>   *
>> - *	ext3_file_write() -> generic_file_write() -> __alloc_pages() -> ...
>> + *	ext3_file_write() -> generic_file_aio_write() -> __alloc_pages() -> ...
>   Well, but ext3_file_write() doesn't exist either so the comment obviously
> needs further updates.
> 
>>   *
>>   * Same applies to ext3_get_block().  We will deadlock on various things like
>>   * lock_journal and i_truncate_mutex.
>> @@ -3212,7 +3212,7 @@ out_brelse:
>>   *
>>   * We are called from a few places:
>>   *
>> - * - Within generic_file_write() for O_SYNC files.
>> + * - Within generic_file_aio_write() for O_SYNC files.
>>   *   Here, there will be no transaction running. We wait for any running
>>   *   transaction to commit.
>>   *
>   This is correct but as I'm looking through the comment it needs much
> larger update. So something like attached patches looks more appropriate.
> Thanks for pointing me to those outdated comments.
> 
> 								Honza
> 
Hi Honza，
	
Your fix is more better than mine. It's a good chance for me to learn, thanks!

								Zhen

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html