linux-ext4 - Re: [PATCH v3 24/30] e2fsck: check inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140304045111.GA12937@gmail.com>
Date:	Tue, 4 Mar 2014 12:51:12 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org,
	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH v3 24/30] e2fsck: check inline_data in pass1

On Mon, Mar 03, 2014 at 05:18:40PM -0500, Theodore Ts'o wrote:
> On Fri, Dec 06, 2013 at 05:58:11PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@...bao.com>
> > 
> > Signed-off-by: Theodore Ts'o <tytso@....edu>
> > Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> 
> With my change to patch 11/30, the following change is needed to this
> patch.
> 
> 						- Ted

Thanks for fixing this.  The patch looks good to me.
Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>
                                                - Zheng

> 
> diff --git a/lib/ext2fs/dblist_dir.c b/lib/ext2fs/dblist_dir.c
> index 1e36584..2fbb772 100644
> --- a/lib/ext2fs/dblist_dir.c
> +++ b/lib/ext2fs/dblist_dir.c
> @@ -78,9 +78,7 @@ static int db_dir_proc(ext2_filsys fs, struct ext2_db_entry2 *db_info,
>  		return DBLIST_ABORT;
>  	if (inode.i_flags & EXT4_INLINE_DATA_FL) {
>  		ctx->flags = DIRENT_FLAG_INCLUDE_INLINE_DATA;
> -		ext2fs_inline_data_dir_iterate(fs, ctx->dir,
> -					       ext2fs_process_dir_block,
> -					       ctx);
> +		ret = ext2fs_inline_data_dir_iterate(fs, ctx->dir, ctx);
>  	} else {
>  		ret = ext2fs_process_dir_block(fs, &db_info->blk,
>  					       db_info->blockcnt, 0, 0,
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html