linux-ext4 - Re: [PATCH V4 05/11] misc/create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140306194715.GA30214@thunk.org>
Date:	Thu, 6 Mar 2014 14:47:15 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Robert Yang <liezhi.yang@...driver.com>, dvhart@...ux.intel.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH V4 05/11] misc/create_inode.c: copy regular file

On Thu, Mar 06, 2014 at 11:06:22AM -0800, Darrick J. Wong wrote:
> I noticed a few things while merging -next into my dev tree...

Darrick, good catch!

> > +	retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
> > +	if (retval) {
> > +		com_err(__func__, retval, 0);
> > +		close(fd);
> > +		return errno;
> 
> Why return errno here, instead of retval?

Yep, we should do s/errno/retval/ at the places that you noted.

Robert, since these are in next already, could you submit a patch to
fixt this up?

Thanks!!

					- Ted

P.S.  Fortunately, this isn't crypto code ala gnutls.  :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html