linux-ext4 - Re: [PATCH 01/49] create_inode: clean up return mess in do_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311210853.GK2190@thunk.org>
Date:	Tue, 11 Mar 2014 17:08:53 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 01/49] create_inode: clean up return mess in
 do_write_internal

On Tue, Mar 11, 2014 at 01:41:31PM -0700, Darrick J. Wong wrote:
> > This seems a bit strange.  It looks like an error return, but it will
> > actually return "0" since this branch is only entered if retval == 0.
> > Should this return an explicit error value here?
> 
> You're right; maybe we should return EXT2_ET_FILE_EXISTS or something?

EXT2_ET_FILE_EXISTS sounds good to me.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html