linux-ext4 - Re: [PATCH 17/49] libext2fs: fix 64bit overflow in ext2fs_block_alloc_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140314133547.GL8282@thunk.org>
Date:	Fri, 14 Mar 2014 09:35:47 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 17/49] libext2fs: fix 64bit overflow in
 ext2fs_block_alloc_stats_range

On Mon, Mar 10, 2014 at 11:55:46PM -0700, Darrick J. Wong wrote:
> In ext2fs_block_alloc_stats_range(), the quantity "-inuse * n" is
> calculated as a signed 32-bit quantity.  Unfortunately, gcc (4.6.3 on
> Ubuntu 12.04) doesn't sign-extend this quantity to fill the blk64_t
> parameter that ext2fs_free_blocks_count_add() wants, so the end result
> is that the superblock gets a ridiculously huge free block count.
> 
> Changing the declaration of 'n' to blk64_t seems to fix this.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html