linux-ext4 - Re: [PATCH 09/49] libext2fs: don't fail when doing a strict rewrite of inline data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140314131914.GD8282@thunk.org>
Date:	Fri, 14 Mar 2014 09:19:14 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/49] libext2fs: don't fail when doing a strict rewrite
 of inline data

On Mon, Mar 10, 2014 at 11:54:56PM -0700, Darrick J. Wong wrote:
> ext2fs_inline_data_set() tries to ensure that there is sufficient free
> space in the inode to store the inline data.  Unfortunately, it gets
> the check wrong -- ext2fs_xattr_inode_max_size() returns the amount of
> unused bytes in the EA area, and _data_set() doesn't factor in the
> size of the existing inline data.  Therefore, a strict rewrite of an
> N-byte inlinedata with another N-byte inlinedata fails.
> 
> Fix the code to do the size check correctly.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html