linux-ext4 - Re: [PATCH 12/49] libext2fs: during inlinedata expand, don't corrupt inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140314132902.GG8282@thunk.org>
Date:	Fri, 14 Mar 2014 09:29:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 12/49] libext2fs: during inlinedata expand, don't corrupt
 inode

On Mon, Mar 10, 2014 at 11:55:15PM -0700, Darrick J. Wong wrote:
> When expanding an inline data inode, it's possible that the reduction
> in the size of the EA structures causes the freeing of the EA block,
> which changes the inode.  If this happens, the local version of the
> inode that ext2fs_inline_data_expand was modifying will be out of sync
> with what's on the disk.  This local copy gets written out to disk
> after a block allocation, at which point it's possible that the inode
> EA block and logical block zero point to the same physical block,
> which is bad news.
> 
> Therefore, write the local copy to disk before removing the inline
> data EA, and reread it afterwards.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html