linux-ext4 - Re: [PATCH] ext4: initialize multi-block allocator before checking block descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140316161637.GA19885@azat>
Date:	Sun, 16 Mar 2014 20:17:13 +0400
From:	a3at.mail@...il.com
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	"open list:EXT4 FILE SYSTEM" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: initialize multi-block allocator before checking
 block descriptors

On Sun, Mar 16, 2014 at 06:10:12PM +0400, Azat Khuzhin wrote:
> On Sun, Mar 16, 2014 at 6:38 AM,  <tytso@....edu> wrote:
> > On Sun, Mar 16, 2014 at 03:54:34AM +0400, Azat Khuzhin wrote:
> >>
> >> Thanks Ted, I'll take a look.
> >> Are you talking about xfs-tests failures?
> >
> > Yes, the kernel is complaining that the file system looks corrupt.
> > The xfstest generic/001 is the easist one to trigger it:
> >
> > generic/001 18s ...     [17:35:49][   26.793766] EXT4-fs error (device vde): ext4_mb_generate_buddy:756: group 1, 32763 clusters in bitmap, 32764
> > in gd; block bitmap corrupt.
> >  [17:36:09] 20s
> > [   39.636943] EXT4-fs (vde): warning: mounting fs with errors, running e2fsck is recommended
> >
> > I this was using a freshly generated file system using a 20 GiB test
> > partition, formatted using:
> >
> >            mke2fs -t ext4 -O bigalloc /dev/vde
> >
> > Dropping the patch made the error go away.
> 
> Hi Ted,
> 
> I just checked with the last upstream commit d8ec26d7f8287 + patch,
> and xfs tests haven't fallen
> I even update xfstests, still nothing.
> 
> /src/xfstests # git describe
> linux-v3.8-336-g3948694
> 
> /src/xfstests # ./run_generic.sh
> mke2fs 1.42.8 (20-Jun-2013)
> /dev/sdb1 is mounted; will not make a filesystem here!
> FSTYP         -- ext4
> PLATFORM      -- Linux/x86_64 debian-virtual-2-6-39 3.13.0+
> MKFS_OPTIONS  -- /dev/sdc1
> MOUNT_OPTIONS -- -O bigalloc /dev/sdc1 /xfs-playground/scratch
> 
> generic/001 2s ... 2s
> Ran: generic/001
> Passed all 1 tests
> 
> # uname -r
> 3.13.0+
> 
> Maybe I need more recent kernel?

I've also tested on 3.14.0-rc6+: a4ecdf8 ("Merge branch
'x86-urgent-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip")

And no complaints from xfs-tests, and no errors in dmesg.

Could you give me more information about you playground?

> 
> >
> > Cheers,
> >
> >                                         - Ted
> 
> 
> 
> -- 
> Respectfully
> Azat Khuzhin

-- 
Respectfully
Azat Khuzhin
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html