lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Mar 2014 10:41:58 +0200 (CEST) From: Lukáš Czerner <lczerner@...hat.com> To: Dan Carpenter <dan.carpenter@...cle.com> cc: linux-ext4@...r.kernel.org Subject: re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate On Fri, 28 Mar 2014, Dan Carpenter wrote: > Date: Fri, 28 Mar 2014 11:03:56 +0300 > From: Dan Carpenter <dan.carpenter@...cle.com> > To: lczerner@...hat.com > Cc: linux-ext4@...r.kernel.org > Subject: re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate > > Hello Lukas Czerner, > > The patch 1f0e51771281: "ext4: Introduce FALLOC_FL_ZERO_RANGE flag > for fallocate" from Mar 18, 2014, leads to the following static > checker warning: > > fs/ext4/extents.c:3653 ext4_split_convert_extents() > warn: odd binop '0x4 & 0x10' > > fs/ext4/extents.c > 3650 } else if (flags | EXT4_GET_BLOCKS_CONVERT) { > 3651 split_flag |= ee_block + ee_len <= eof_block ? > 3652 EXT4_EXT_MAY_ZEROOUT : 0; > 3653 split_flag |= (EXT4_EXT_MARK_UNINIT2 & EXT4_EXT_DATA_VALID2); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Right, thanks. -Lukas > This statement is a no-op. Probably | was intended? > > 3654 } > 3655 flags |= EXT4_GET_BLOCKS_PRE_IO; > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists