linux-ext4 - Re: [PATCH 1/2] fsx: Add fallocate collapse range operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140403212637.GP17603@dastard>
Date:	Fri, 4 Apr 2014 08:26:37 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	xfs@....sgi.com, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/2] fsx: Add fallocate collapse range operation

On Wed, Apr 02, 2014 at 05:55:07PM +0200, Lukáš Czerner wrote:
> On Wed, 2 Apr 2014, Lukas Czerner wrote:
> 
> > Date: Wed,  2 Apr 2014 17:33:19 +0200
> > From: Lukas Czerner <lczerner@...hat.com>
> > To: xfs@....sgi.com
> > Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
> >     Lukas Czerner <lczerner@...hat.com>
> > Subject: [PATCH 1/2] fsx: Add fallocate collapse range operation
> > 
> > This commit adds fallocate FALLOC_FL_COLLAPSE_RANGE support for fsx.
> 
> Btw, this actually makes the fsx fail on ext4 and xfs after a while.
> I was trying to find a problem in fsx itself but I think it is
> actually ok. That means that we could possibly have bugs in ext4 and
> xfs collapse range implementation. More eyes are needed on this!

No surprise, really. As it is, your previous ZERO_RANGE additions
caused problems for XFS, and those are mostly fixed in the 6 patch
series I sent before LSFMM.  Hence I wouldn't be surprised if that's
what you are seeing (on XFs, at least) and it's not actually
COLLAPSE_RANGE that is causing problems...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html