linux-ext4 - Re: [PATCH V2] ext4: FIBMAP ioctl causes BUG_ON due to handle EXT_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140407143632.GA25478@thunk.org>
Date:	Mon, 7 Apr 2014 10:36:32 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Kazuya Mio <k-mio@...jp.nec.com>
Cc:	"adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH V2] ext4: FIBMAP ioctl causes BUG_ON due to handle
 EXT_MAX_BLOCKS

On Fri, Apr 04, 2014 at 08:02:58AM +0000, Kazuya Mio wrote:
> When we try to get 2^32-1 block of the file which has the extent
> (ee_block=2^32-2, ee_len=1) with FIBMAP ioctl, it causes BUG_ON
> in ext4_ext_put_gap_in_cache().
> 
> To avoid the problem, ext4_map_blocks() needs to check the file logical block
> number. ext4_ext_put_gap_in_cache() called via ext4_map_blocks() cannot
> handle 2^32-1 because the maximum file logical block number is 2^32-2.
> 
> Note that ext4_ind_map_blocks() returns -EIO when the block number is invalid.
> So ext4_map_blocks() should also return the same errno.
> 
> Signed-off-by: Kazuya Mio <k-mio@...jp.nec.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html