linux-ext4 - Pretty-printing file.f_mode and file.f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <nsxa9brqyys.fsf@closure.thunk.org>
Date:	Fri, 11 Apr 2014 18:32:27 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Cc:	rostedt@...dmis.org, trond.myklebust@...marydata.com
Subject: Pretty-printing file.f_mode and file.f_flags in trace points


I want to add some trace points which display f_mode and f_flags from
struct file in a human way.   I found the following handy macros defined
in fs/nfs/nfstrace.h:

#define show_open_flags(flags) \
	__print_flags((unsigned long)flags, "|", \
		{ O_CREAT, "O_CREAT" }, \
		{ O_EXCL, "O_EXCL" }, \
		{ O_TRUNC, "O_TRUNC" }, \
		{ O_APPEND, "O_APPEND" }, \
		{ O_DSYNC, "O_DSYNC" }, \
		{ O_DIRECT, "O_DIRECT" }, \
		{ O_DIRECTORY, "O_DIRECTORY" })

#define show_fmode_flags(mode) \
	__print_flags(mode, "|", \
		{ ((__force unsigned long)FMODE_READ), "READ" }, \
		{ ((__force unsigned long)FMODE_WRITE), "WRITE" }, \
		{ ((__force unsigned long)FMODE_EXEC), "EXEC" })

I could just cut and paste these and drop them in
include/trace/events/ext4.h, but it would probably be better to have a
common header file.  The question is where to put them.  Does
include/trace/fs.h make sense to everyone?   Or should put them
somewhere else, such as linux/fs.h?

Cheers,

                                                - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html