linux-ext4 - Re: [PATCH v2] ext4: fix shared/002 and 004 fail issue in xfstests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Apr 2014 22:59:37 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	linux-ext4@...r.kernel.org, Namjae Jeon <namjae.jeon@...sung.com>,
	Ashish Sangwan <a.sangwan@...sung.com>
Subject: Re: [PATCH v2] ext4: fix shared/002 and 004 fail issue in xfstests

On Wed, Apr 09, 2014 at 10:54:29PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> When mounting ext4 with data=journal option, xfstest shared/002 and
> shared/004 are currently failing as checksum computed for testfile
> does not match with the checksum computed in other journal modes.
> In case of data=journal mode, a call to filemap_write_and_wait_range
> will not flush anything to disk as buffers are not marked dirty in
> write_end. In collapse range this call is followed by a call to
> truncate_pagecache_range. Due to this, when checksum is computed,
> a portion of file is re-read from disk which replace valid data with
> NULL bytes and hence the reason for the difference in checksum.
> 
> Calling ext4_force_commit before filemap_write_and_wait_range solves
> the issue as it will mark the buffers dirty during commit transaction
> which can be later synced by a call to filemap_write_and_wait_range.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html