linux-ext4 - [PATCH] ext4: avoid unneeded lookup when xattr name is invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5347967B.5090401@huawei.com>
Date:	Fri, 11 Apr 2014 15:15:07 +0800
From:	Zhang Zhen <zhenzhang.zhang@...wei.com>
To:	<tytso@....edu>, Christoph Hellwig <hch@...radead.org>
CC:	<linux-ext4@...r.kernel.org>
Subject: [PATCH] ext4: avoid unneeded lookup when xattr name is invalid

In ext4_xattr_set_handle() we have checked the xattr name's length. So we should
also check it in ext4_xattr_get() to avoid unneeded lookup caused by invalid name.

In addition, we deleted the check of NULL in ext4_xattr_set_handle(), because in all
the callers of the ext4_xattr_set_handle(), the name can't be NULL.

Signed-off-by: Zhang Zhen <zhenzhang.zhang@...wei.com>
---
 fs/ext4/xattr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 1f5cf58..340bdfa 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -369,6 +369,9 @@ ext4_xattr_get(struct inode *inode, int name_index, const char *name,
 {
 	int error;

+	if (strlen(name) > 255)
+		return -ERANGE;
+
 	down_read(&EXT4_I(inode)->xattr_sem);
 	error = ext4_xattr_ibody_get(inode, name_index, name, buffer,
 				     buffer_size);
@@ -1073,8 +1076,6 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
 	unsigned long no_expand;
 	int error;

-	if (!name)
-		return -EINVAL;
 	if (strlen(name) > 255)
 		return -ERANGE;
 	down_write(&EXT4_I(inode)->xattr_sem);
-- 
1.8.5.5


.




--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html