| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1397585302-27175-1-git-send-email-lczerner@redhat.com> Date: Tue, 15 Apr 2014 20:08:21 +0200 From: Lukas Czerner <lczerner@...hat.com> To: linux-ext4@...r.kernel.org Cc: Lukas Czerner <lczerner@...hat.com> Subject: [PATCH 1/2] ext4: Remove arbitrary block value in __es_remove_extent() In __es_remove_extent() we're storing seemingly arbitrary value 0x7FDEADBEEF into block variable. I assume that the reason is just to initialize the variable before the use because the actual value does not matter at this point. Just remove the arbitrary value and initialized block variable to zero which is much less suspicious. Signed-off-by: Lukas Czerner <lczerner@...hat.com> --- fs/ext4/extents_status.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index 33682aa..3c47b4e 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ext4/extents_status.c @@ -782,7 +782,7 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk, struct extent_status *es; struct extent_status orig_es; ext4_lblk_t len1, len2; - ext4_fsblk_t block; + ext4_fsblk_t block = 0; int err; retry: @@ -810,7 +810,6 @@ retry: newes.es_lblk = end + 1; newes.es_len = len2; - block = 0x7FDEADBEEF; if (ext4_es_is_written(&orig_es) || ext4_es_is_unwritten(&orig_es)) block = ext4_es_pblock(&orig_es) + -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists