linux-ext4 - Re: [RFC PATCH v2 0/4] ext4: extents status tree shrinker improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140416151938.GA17208@thunk.org>
Date:	Wed, 16 Apr 2014 11:19:38 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	Jan Kara <jack@...e.cz>
Subject: Re: [RFC PATCH v2 0/4] ext4: extents status tree shrinker improvement

Hi Zheng,

Thanks so much for your deep and detailed work on this.

I have two immediate reactions.

1) We should first fix __ext4_es_shrink so that we interpret
nr_to_scan correctly --- it's the number of objects to scan, not the
number of objects that we need to shirnk.  That should significantly
reduce the number of scans that we do, and fixing this could
potentially influence the metrics that we measure.

2) In addition to measuring the scan time, we should also measure how
many times we end up loading extents from disk when (during the course
of a normal workload) we are under memory pressure, and RR ends up
throwing out an extent that would have been saved in LRU, and so an
additional metadata read would be required when using RR.

	   	    	       	  	   - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html