linux-ext4 - Re: [PATCH 2/5] ext4: fix removing status extents in ext4_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140418144436.GC19131@thunk.org>
Date:	Fri, 18 Apr 2014 10:44:36 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	'Lukas Czerner' <lczerner@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/5] ext4: fix removing status extents in
 ext4_collapse_range()

On Thu, Apr 17, 2014 at 02:54:18PM +0900, Namjae Jeon wrote:
> > Currently in ext4_collapse_range() when calling ext4_es_remove_extent() to
> > remove status extents we're passing (EXT_MAX_BLOCKS - punch_start - 1)
> > in order to remove all extents from start of the collapse range to the
> > end of the file. However this is wrong because we might miss the
> > possible extent covering the last block of the file.
> > 
> > Fix it by removing the -1.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Looks good to me! 
> 
> Reviewed-by: Namjae Jeon <namjae.jeon@...sung.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html