linux-ext4 - Re: [PATCH v2 2/2] ext4: disable COLLAPSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140421133119.GD14869@thunk.org>
Date:	Mon, 21 Apr 2014 09:31:19 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	'linux-ext4' <linux-ext4@...r.kernel.org>,
	'Lukáš Czerner' <lczerner@...hat.com>
Subject: Re: [PATCH v2 2/2] ext4: disable COLLAPSE_RANGE for bigalloc

On Mon, Apr 21, 2014 at 01:52:28PM +0900, Namjae Jeon wrote:
> > 
> > What's the status of the "[2/3] ext4: fix ZERO_RANGE test failure in
> > data journalling mode" patch.  Is it no longer needed?
> It is needed. Currently, I am considering your suggestion of introducing
> EXT4_I(inode)->i_write_mutex which can also include ext4_aio_mutex.

OK; I've already pushed a set of patches to Linus because it's getting
fairly late in the development cycle, and we really want to get as
much of the bug fixes into -rc3 (having missed -rc2 by a few hours,
sigh).

By the way, in doing some final testing, it appears that we are still
failing generic/127 with a 1k blocksize.  If I block COLLAPSE_RANGE
using the patch that everyone but me seems to hate :-), the problem
goes away.  So we have at least one other issue that needs to be
looked at.

You can reproduce by grabbing the dev branch from the ext4.git tree,
and then cherry-picking the top commit from the unstable branch.

Then run "kvm-xfstests -c 1k generic/127", with and without the
following in config.custom:

EXTRA_ARG="ext4.fallocate_mode_block=0x08"

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html