linux-ext4 - Re: [PATCH 7/7] mke2fs: only print the low-level file system stats in verbose mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1404301616380.2100@localhost.localdomain>
Date:	Wed, 30 Apr 2014 16:25:35 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 7/7] mke2fs: only print the low-level file system stats
 in verbose mode

On Wed, 30 Apr 2014, Theodore Ts'o wrote:

> Date: Wed, 30 Apr 2014 10:01:50 -0400
> From: Theodore Ts'o <tytso@....edu>
> To: Lukáš Czerner <lczerner@...hat.com>
> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>
> Subject: Re: [PATCH 7/7] mke2fs: only print the low-level file system stats in
>      verbose mode
> 
> On Wed, Apr 30, 2014 at 01:22:52PM +0200, Lukáš Czerner wrote:
> > On Sat, 26 Apr 2014, Theodore Ts'o wrote:
> > 
> > > Date: Sat, 26 Apr 2014 20:00:34 -0400
> > > From: Theodore Ts'o <tytso@....edu>
> > > To: Ext4 Developers List <linux-ext4@...r.kernel.org>
> > > Cc: Theodore Ts'o <tytso@....edu>
> > > Subject: [PATCH 7/7] mke2fs: only print the low-level file system stats in
> > >     verbose mode
> > 
> > While I kind of like this, because mke2fs is really quite verbose as
> > it is. However I am afraid that this will break scripts for people.
> 
> Are there scripts that are really trying to parse the output of
> mke2fs?  The output hasn't really been _that_ stable.  I'm sure we've
> added stuff in the past, althoughg admittedly the this is the first
> time that we would be removing stuff.

Yes, that's what I worry about. Addition would most likely not break
grep, but removal will surely do. I am sure that there are admins
doing that.

It also does not help that other file systems are printing out
various "low level" information.

Despite the fact that parsing mkfs output is not the best thing to
do I am on the fence whether we want to break it or not.

> 
> > Also there are actually some useful information in that output like
> > block size, size of the file system and file system label if
> > specified. Also maybe having UUID in there will be also useful.
> 
> The block sizs is pretty much always 4k, and the file system label is
> only there if the user specified one on the command line.  I can see
> how the size and UUID might be useful, though.
> 
> How about if we just print the size and UUID?

Sounds good to me.

-Lukas

> 
> 						- Ted
>