linux-ext4 - Re: [PATCH V2] mke2fs: prevent creation of filesystem with unsupported revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C8AA9B5-1F12-4016-9EFB-1960A565DD09@dilger.ca>
Date:	Thu, 1 May 2014 16:20:40 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Frank Sorenson <fsorenso@...hat.com>
Subject: Re: [PATCH V2] mke2fs: prevent creation of filesystem with unsupported revision

On May 1, 2014, at 2:39 PM, Eric Sandeen <sandeen@...hat.com> wrote:

> From: Frank Sorenson <fsorenso@...hat.com>
> 
> Don't create a filesystem with an unsupported revision number

I like the commit comment on the original patch better...

Cheers, Andreas

> Signed-off-by: Frank Sorenson <fsorenso@...hat.com>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> V2: Frank did this independently, and it's better.  I forgot about
> using com_err here.
> 
> --- a/misc/mke2fs.c	
> +++ a/misc/mke2fs.c	
> @@ -1684,6 +1684,11 @@ profile_error:
> 					_("bad revision level - %s"), optarg);
> 				exit(1);
> 			}
> +			if (r_opt > EXT2_MAX_SUPP_REV) {
> +				com_err(program_name, EXT2_ET_REV_TOO_HIGH,
> +					_("while trying to create revision %d"), r_opt);
> +				exit(1);
> +			}
> 			fs_param.s_rev_level = r_opt;
> 			break;
> 		case 's':	/* deprecated */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)