lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140507123913.GA28814@thunk.org> Date: Wed, 7 May 2014 08:39:13 -0400 From: Theodore Ts'o <tytso@....edu> To: Lukáš Czerner <lczerner@...hat.com> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org> Subject: Re: [PATCH -v2 2/3] mke2fs: print extra information about existing ext2/3/4 file systemsG On Wed, May 07, 2014 at 10:15:56AM +0200, Lukáš Czerner wrote: > > Yes, that's a cut and paste typo, thanks for spotting it. It should > > have been: > > > > } else if (sb->s_mkfs_time) { > > tm = sb->s_mkfs_time; > > printf(_("\tcreated on %s"), ctime(&tm)); > > } else if (sb->s_mtime) { <======== > > But you're already checking for sb->s_mtime in the first condition, > am I missing something ? The basic idea is to give one bit of context, and whatever would be the most useful. In order of preference, it's: 1) Last mount directory (if available) and last mount time 2) Time file system was created 3) Time file system was written #2 or #3 is only needed if the file system was never mounted. #3 is only needed for those file systems that (a) were never mounted, (b) was modified/filled via e2tools or debugfs. (Or Windows FS SDK based hacks, etc.) - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists