| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <536AEE3D.6090502@gmail.com> Date: Thu, 08 May 2014 10:38:53 +0800 From: Niu Yawei <yawei.niu@...il.com> To: tytso@....edu, linux-ext4@...r.kernel.org CC: yawei.niu@...el.com Subject: [PATCH] libext2fs: fix dict_uint_cmp() dict_uint_cmp() returns an usigned int value in int type, which could mess the dict key comparison when the difference of two keys is greater than INT_MAX. Signed-off-by: Niu Yawei <yawei.niu@...el.com> --- lib/quota/mkquota.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/lib/quota/mkquota.c b/lib/quota/mkquota.c index 9883216..ba8c2da 100644 --- a/lib/quota/mkquota.c +++ b/lib/quota/mkquota.c @@ -207,7 +207,12 @@ static int dict_uint_cmp(const void *a, const void *b) c = VOIDPTR_TO_UINT(a); d = VOIDPTR_TO_UINT(b); - return c - d; + if (c == d) + return 0; + else if (c > d) + return 1; + else + return -1; } static inline qid_t get_qid(struct ext2_inode *inode, int qtype) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists