lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140511224011.GD5480@thunk.org> Date: Sun, 11 May 2014 18:40:11 -0400 From: Theodore Ts'o <tytso@....edu> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: Lukáš Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org Subject: Re: [PATCH 02/37] misc: coverity fixes Applied, with Lukáš's nits addressed. One comment: > > > @@ -612,7 +616,7 @@ static errcode_t __populate_fs(ext2_filsys fs, ext2_ino_t parent_ino, > > > if (p == NULL) { > > > com_err(name, errno, > > > _("Not enough memory")); > > > - return errno; > > > + goto out; > > > > same here. > > Yes. Thank you for spotting these. The original code was buggy here, since realloc() doesn't set errno. I've added: retval = EXT2_ET_NO_MEMORY; before the "goto out" line. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists