[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140512142457.GG31376@thunk.org>
Date: Mon, 12 May 2014 10:24:57 -0400
From: Theodore Ts'o <tytso@....edu>
To: "Darrick J. Wong" <darrick.wong@...cle.com>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/5] ext4: don't crash when validating block bitmap
On Thu, May 01, 2014 at 04:17:47PM -0700, Darrick J. Wong wrote:
> If EXT4FS_DEBUG is defined, ext4_validate_block_bitmap is called via
> ext4_count_free_clusters before sb->s_group_info is set up. When this
> happens, the kernel crashes because group info hasn't been loaded.
> Forego marking the group corrupt for now; not setting BH_Verified
> means we'll revisit the bitmap if something went wrong.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
This shouldn't be necessary that we have this in the ext4 tree, right?
commit 007649375f6af242d5b1df2c15996949714303ba
Author: Azat Khuzhin <a3at.mail@...il.com>
Date: Mon Apr 7 10:54:20 2014 -0400
ext4: initialize multi-block allocator before checking block descriptors
With EXT4FS_DEBUG ext4_count_free_clusters() will call
ext4_read_block_bitmap() without s_group_info initialized, so we need to
initialize multi-block allocator before.
...
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists