linux-ext4 - Re: [PATCH] e2fsprogs: don't run quota test if quota is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <537A82D0.8030702@redhat.com>
Date:	Mon, 19 May 2014 17:16:48 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: don't run quota test if quota is not enabled

On 5/19/14, 3:26 PM, Eric Sandeen wrote:
> The default configuration still has quota disabled, but
> runs the f_quota test unconditionally, so we fail by
> default.
> 
> Fix that...

related to this, should quota be on by default now, or not?

also: my old fedora package (not built with --enable-quota) installed
a quota.pc and a /usr/include/quota dir.  But when I built today
with --enable-quota, those *didn't* show up.

TBH I get lost in the makefiles... should quota be on yet, or not?
Is libquota supposed to be installed if it's on?

Thanks,
-Eric

> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> diff --git a/tests/f_quota/script b/tests/f_quota/script
> index bf25e07..d1c4b9e 100644
> --- a/tests/f_quota/script
> +++ b/tests/f_quota/script
> @@ -1,4 +1,11 @@
>  AFTER_CMD='$DEBUGFS -f $test_dir/debugfs-cmds $TMPFILE 2>&1 | sed -f $cmd_dir/filter.sed > $test_name.0.log'
>  PASS_ZERO=true
>  
> +$TUNE2FS -h 2>&1 | grep -q quota_options
> +if [ $? != 0 ] ; then
> +        rm -f $TMPFILE
> +        echo "$test_name: $test_description: skipped (quota not enabled)"
> +        return 0
> +fi
> +
>  . $cmd_dir/run_e2fsck
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html