lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <537CE3E1.10406@redhat.com> Date: Wed, 21 May 2014 12:35:29 -0500 From: Eric Sandeen <sandeen@...hat.com> To: ext4 development <linux-ext4@...r.kernel.org> Subject: [PATCH] mke2fs: use ext2fs_open_file() in check_plausibility() The commit: 802146c mke2fs: create a regular file if necessary caused a regression on 32-bit machines; the open() fails if the file size is > 4G. Using ext2fs_open_file() fixes it. Resolves: Red Hat Bugzilla #1099892 Signed-off-by: Eric Sandeen <sandeen@...hat.com> --- TBH I don't know if this should be using ext2fs_open_file(), or some other magic like O_LARGEFILE, but this works for me, and we use the stat/fstat wrapper here too, so ... diff --git a/misc/util.c b/misc/util.c index f85942e..d638625 100644 --- a/misc/util.c +++ b/misc/util.c @@ -94,7 +94,7 @@ int check_plausibility(const char *device, int flags, int *ret_is_dev) if (flags & CREATE_FILE) fl |= O_CREAT; - fd = open(device, fl, 0666); + fd = ext2fs_open_file(device, fl, 0666); if (fd < 0) { fprintf(stderr, _("Could not open %s: %s\n"), device, error_message(errno)); -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists