lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140521134158.GB4719@vaio> Date: Wed, 21 May 2014 14:41:58 +0100 From: Giedrius Rekasius <giedrius.rekasius@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...) On Tue, May 20, 2014 at 11:08:27PM +0300, Dan Carpenter wrote: > On Tue, May 20, 2014 at 03:41:13PM +0100, Giedrius Rekasius wrote: > > From: Giedrius Rekasius <giedrius.rekasius@...il.com> > > > > Remove unused local variable "store" from ext4_readdir(...) > > > > Local variable "stored" is initialized however never used inside the function. > > > > Signed-off-by: Giedrius Rekasius <giedrius.rekasius@...il.com> > > You email client is corrupting the patch so it doesn't apply. > > Read Documentation/email-clients.txt (linux-next version). Indeed the patch was corrupt, my apologies for that. Patch resubmission below. From: Giedrius Rekasius <giedrius.rekasius@...il.com> Remove unused local variable "store" from ext4_readdir(...) Local variable "stored" is initialized however never used inside the function. Signed-off-by: Giedrius Rekasius <giedrius.rekasius@...il.com> --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index d638c57..ef1bed6 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -105,7 +105,7 @@ int __ext4_check_dir_entry(const char *function, unsigned int line, static int ext4_readdir(struct file *file, struct dir_context *ctx) { unsigned int offset; - int i, stored; + int i; struct ext4_dir_entry_2 *de; int err; struct inode *inode = file_inode(file); @@ -133,7 +133,6 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx) return ret; } - stored = 0; offset = ctx->pos & (sb->s_blocksize - 1); while (ctx->pos < inode->i_size) { -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists