linux-ext4 - Re: [PATCH] misc: fix create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140527165121.GD1158@thunk.org>
Date:	Tue, 27 May 2014 12:51:21 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] misc: fix create_inode warnings with LLVM

On Tue, May 27, 2014 at 06:34:52PM +0200, Lukáš Czerner wrote:
> On Tue, 20 May 2014, Andreas Dilger wrote:
> 
> > Date: Tue, 20 May 2014 17:12:22 -0600
> > From: Andreas Dilger <adilger@...ger.ca>
> > To: tytso@....edu
> > Cc: linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...ger.ca>
> > Subject: [PATCH] misc: fix create_inode warnings with LLVM
> > 
> > Fix name clash in do_mknod_internal() due to local variables named
> > "major" and "minor" shadowing identical macro names.
> > 
> > Also, no need to set the major and minor device for a FIFO inode.
> > 
> > Signed-off-by: Andreas Dilger <adilger@...ger.ca>
> 
> Looks good, thanks!
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Applied, thanks.

				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html