lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6394184.hHtXJE2Bp6@wuerfel> Date: Sat, 31 May 2014 16:32:58 +0200 From: Arnd Bergmann <arnd@...db.de> To: "H. Peter Anvin" <hpa@...or.com> Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, joseph@...esourcery.com, john.stultz@...aro.org, hch@...radead.org, tglx@...utronix.de, geert@...ux-m68k.org, lftan@...era.com, linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org Subject: Re: [RFC 13/32] ext3: convert to struct inode_time On Saturday 31 May 2014 02:10:45 H. Peter Anvin wrote: > On 05/30/2014 01:01 PM, Arnd Bergmann wrote: > > ext3fs uses unsigned 32-bit seconds for inode timestamps, which will work > > for the next 92 years, but the VFS uses struct timespec for timestamps, > > which is only good until 2038 on 32-bit CPUs. > > > > This gets us one small step closer to lifting the VFS limit by using > > struct inode_time in ext3. The on-disk format limit is lifted in ext4, > > which will work until 2514. > > > > This may be what the spec says, but when I experimented with this just > now it does seem that both ext2 and ext3 actually interpret timestamps > as *signed* 32-bit seconds. Right, I can see that in ext3_iget() now: inode->i_atime.tv_sec = (signed)le32_to_cpu(raw_inode->i_atime); I may have just looked at ext3_do_update_inode(), which uses this unsigned conversion: raw_inode->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec); and didn't realize that this is only half of the story, and since it converts from (potentially 64-bit) long to u32, it doesn't matter whether that is signed or unsigned. I may have to go through all of them again to see if I made the same mistake in other file systems as well. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists