linux-ext4 - Re: [2/4 v2] e2fsck: make a prompt message simpler and thus translatable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Jun 2014 12:03:21 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Benno Schulenberg <bensberg@...temail.net>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [2/4 v2] e2fsck: make a prompt message simpler and thus
 translatable

On Wed, Jun 04, 2014 at 05:38:12PM +0200, Benno Schulenberg wrote:
> On Wed, Jun 4, 2014, at 16:42, Theodore Ts'o wrote:
> > So it looks like allowing the placement of the XXX characters in the
> > middle of the filename is a GNU coreutils extension, and it must have
> > been introduced very shortly after Ubuntu 10.04 snapshotted its
> > coreutils package from Debian.
> 
> You are right.  On Wed Nov 4 2009 there is this in coreutils' git:
> 
> -TEMPLATE must end in at least 3 consecutive `X's.\n\
> +TEMPLATE must contain at least 3 consecutive `X's in last component.\n\
> 
> and:
> 
> -count_trailing_X_s (const char *s)
> +count_consecutive_X_s (const char *s, size_t len)
> 
> So, you can probably drop the patch.

Well, I actually care about portability to *BSD and other legacy Unix
systems :-), so I plan to the change to push the XXXXXX to the end of
the template.

Thanks for pointing this out,

							- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html