linux-ext4 - Re: [PATCH] tests: for mktemp the exes must be the final characters of the name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jun 2014 16:31:21 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Benno Schulenberg <bensberg@...temail.net>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: for mktemp the exes must be the final characters of the name

On Jun 4, 2014, at 6:28 AM, Benno Schulenberg <bensberg@...temail.net> wrote:
> Signed-off-by: Benno Schulenberg <bensberg@...temail.net>
> ---
> tests/scripts/resize_test |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/scripts/resize_test b/tests/scripts/resize_test
> index c9a7a1c..1e5756c 100755
> --- a/tests/scripts/resize_test
> +++ b/tests/scripts/resize_test
> @@ -21,7 +21,7 @@ if truncate -s $SIZE_2 $TMPFILE 2> /dev/null; then
> 	echo "using $TMPFILE" >> $LOG
> else
> 	rm $TMPFILE
> -	export TMPFILE=$(TMPDIR=. mktemp -t $test_name.XXXXXX.tmp)
> +	export TMPFILE=$(TMPDIR=. mktemp -t $test_name.tmp.XXXXXX)

The goal was that the temporary file ended with ".tmp" so that it would
be removed by "make clean" in case the test fails or is interrupted, so
it would be good to update the "make clean" rules to find these files.

I also notice that there are occasional e2fsprogs-tmp.XXXXXX files left
behind in /tmp after testing, and it would be nice if they contained the
test name so they can be found if there is a problem.

It looks like the same could be done in tests/test_one.in:

TMPFILE=$(mktemp -t e2fsprogs-$test_name.tmp.XXXXXX)

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)