linux-ext4 - Re: [PATCH 1/2] ext4: introduce new i_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140608024823.GA3984@thunk.org>
Date:	Sat, 7 Jun 2014 22:48:23 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	'Lukáš Czerner' <lczerner@...hat.com>,
	'linux-ext4' <linux-ext4@...r.kernel.org>,
	'Ashish Sangwan' <a.sangwan@...sung.com>
Subject: Re: [PATCH 1/2] ext4: introduce new i_write_mutex to protect
 fallocate

On Wed, Jun 04, 2014 at 02:58:06PM +0900, Namjae Jeon wrote:
> Yes, It is there but as Lukas said it is not critical than a possible
> locking overhead. So, IMHO this is not something which needs urgent
> attention and can be tackled properly after checking unclear
> performance measurement on high-end server.

Fair enough, I've done my own testing and with the following modified
version of that patch it does seem to mostly avoid the xfstest failure
(even if there still is the possibility of a race).  So I'll drop the
i_write_mutex patch for now and make the necessary changes to the "fix
ZERO_RANGE test failure in data journalling" to avoid taking the
now-removed i_write_mutex.

Cheers,

						- Ted


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html