linux-ext4 - Re: [PATCH] fs/ext2/super.c: Drop memory allocation cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 14:14:54 +0200
From:	Jan Kara <jack@...e.cz>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH] fs/ext2/super.c: Drop memory allocation cast

On Tue 10-06-14 20:11:18, Himangi Saraogi wrote:
> Drop cast on the result of kmem_cache_alloc.
> 
> The semantic patch that makes this change is as follows:
> 
> // <smpl>
> @@
> type T;
> @@
> 
> - (T *)
>   (\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|
>    kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...))
> // </smpl>
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
  Merged to my tree. Thanks!

								Honza
> ---
>  fs/ext2/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 3750031..b88edc0 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -161,7 +161,7 @@ static struct kmem_cache * ext2_inode_cachep;
>  static struct inode *ext2_alloc_inode(struct super_block *sb)
>  {
>  	struct ext2_inode_info *ei;
> -	ei = (struct ext2_inode_info *)kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
> +	ei = kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
>  	if (!ei)
>  		return NULL;
>  	ei->i_block_alloc_info = NULL;
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html