linux-ext4 - Re: [PATCH 20/24] ext4: return actual error on ext4_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1406171712170.2148@localhost.localdomain>
Date:	Tue, 17 Jun 2014 17:13:27 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Jeff Liu <jeff.liu@...cle.com>
cc:	"Theodore Ts'o" <tytso@....edu>,
	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 20/24] ext4: return actual error on ext4_init_fs

On Tue, 17 Jun 2014, Jeff Liu wrote:

> Date: Tue, 17 Jun 2014 22:32:54 +0800
> From: Jeff Liu <jeff.liu@...cle.com>
> To: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 20/24] ext4: return actual error on ext4_init_fs
> 
> From: Jie Liu <jeff.liu@...cle.com>
> 
> Return the actual error code if call kset_create_and_add() failed

Considering the rest of the series this looks good to me. Thanks!

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> Cc: Theodore Ts'o <tytso@....edu>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> Signed-off-by: Jie Liu <jeff.liu@...cle.com>
> ---
>  fs/ext4/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index b9b9aab..5912193 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5545,8 +5545,8 @@ static int __init ext4_init_fs(void)
>  	if (err)
>  		goto out6;
>  	ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj);
> -	if (!ext4_kset) {
> -		err = -ENOMEM;
> +	if (IS_ERR(ext4_kset)) {
> +		err = PTR_ERR(ext4_kset);
>  		goto out5;
>  	}
>  	ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html