linux-ext4 - RE: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <003a01cf8b7a$33bd03d0$9b370b70$@samsung.com>
Date:	Thu, 19 Jun 2014 13:51:58 +0900
From:	Namjae Jeon <namjae.jeon@...sung.com>
To:	'Theodore Ts'o' <tytso@....edu>
Cc:	'linux-ext4' <linux-ext4@...r.kernel.org>,
	'Ashish Sangwan' <a.sangwan@...sung.com>
Subject: RE: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is
 enable

 On Wed, Jun 04, 2014 at 05:08:45PM +0900, Namjae Jeon wrote:
> > Blocks in collapse range should be collapsed per cluster unit when bigalloc
> > is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will be same with
> > EXT4_BLOCK_SIZE.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
> 
> Correct me if I'm wrong, but this patch enables COLLAPSE_RANGE when
> bigalloc is enabled.  The commit description (and the one-line
> summary) should emphasize this.
Yes, You're right. I will update description.
> 
> And I assume you've run a full xfstests auto run with bigalloc and
> everything passed?
Yes, kvm-test is passed with no issues.(kvm-xfstests -c bigalloc -g auto,
kvm-xfstests -c bigalloc_1k -g auto)
In order to run collapse range xfstests with bigalloc, I had to make some changes.
1) In case of collapse, fsx and fsstress use block aligned paramteres, but for
bigalloc it has to be cluster size aligned. I am not aware of any method by which
ext4 can tell cluster size to user space so I changed fsx and fsstress code to use
hard coded 64KB cluster size alignment.

2) xfstests which tests corner cases for collapse could not be executed with
bigalloc as they are written keeping in mind that blocksize >= 4096.
So, for testing purpose. I changed the multiple factor in function
_test_generic_punch to 64 from 4. Also, the corresponding .out files has to
be changed.

I am looking for a proper way to integrate these changes in xfstests.

Thanks!
> 
> Thanks,
> 
> 						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html