linux-ext4 - Re: [PATCH] msync: fix incorrect fstart calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2014 13:51:11 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Namjae Jeon <namjae.jeon@...sung.com>
cc:	"'Andrew Morton'" <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	"'Matthew Wilcox'" <matthew.r.wilcox@...el.com>,
	"'Eric Whitney'" <enwlinux@...il.com>,
	Ashish Sangwan <a.sangwan@...sung.com>
Subject: Re: [PATCH] msync: fix incorrect fstart calculation

On Fri, 27 Jun 2014, Namjae Jeon wrote:

> Date: Fri, 27 Jun 2014 20:38:49 +0900
> From: Namjae Jeon <namjae.jeon@...sung.com>
> To: 'Andrew Morton' <akpm@...ux-foundation.org>
> Cc: linux-mm@...ck.org, linux-ext4 <linux-ext4@...r.kernel.org>,
>     Lukáš Czerner <lczerner@...hat.com>,
>     'Matthew Wilcox' <matthew.r.wilcox@...el.com>,
>     'Eric Whitney' <enwlinux@...il.com>,
>     Ashish Sangwan <a.sangwan@...sung.com>
> Subject: [PATCH] msync: fix incorrect fstart calculation
> 
> Fix a regression caused by Commit 7fc34a62ca mm/msync.c: sync only
> the requested range in msync().
> xfstests generic/075 fail occured on ext4 data=journal mode because
> the intended range was not syncing due to wrong fstart calculation.

Looks good to me and it fixes the issues with data=journal on ext4.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>
Tested-by: Lukas Czerner <lczerner@...hat.com>

> 
> Cc: Matthew Wilcox <matthew.r.wilcox@...el.com>
> Cc: Lukáš Czerner <lczerner@...hat.com>
> Reported-by: Eric Whitney <enwlinux@...il.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
> ---
>  mm/msync.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/msync.c b/mm/msync.c
> index a5c6736..ad97dce 100644
> --- a/mm/msync.c
> +++ b/mm/msync.c
> @@ -78,7 +78,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
>  			goto out_unlock;
>  		}
>  		file = vma->vm_file;
> -		fstart = start + ((loff_t)vma->vm_pgoff << PAGE_SHIFT);
> +		fstart = (start - vma->vm_start) +
> +			 ((loff_t)vma->vm_pgoff << PAGE_SHIFT);
>  		fend = fstart + (min(end, vma->vm_end) - start) - 1;
>  		start = vma->vm_end;
>  		if ((flags & MS_SYNC) && file &&
>