linux-ext4 - Re: [PATCH] ext4: remove readpage() check up for mmap file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404314153.24795.4.camel@rzwisler-mobl1.amr.corp.intel.com>
Date:	Wed, 2 Jul 2014 15:15:54 +0000
From:	"Zwisler, Ross" <ross.zwisler@...el.com>
To:	"zhenzhang.zhang@...wei.com" <zhenzhang.zhang@...wei.com>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"jack@...e.cz" <jack@...e.cz>, "tytso@....edu" <tytso@....edu>
Subject: Re: [PATCH] ext4: remove readpage() check up for mmap file

On Wed, 2014-07-02 at 12:01 +0800, Zhang Zhen wrote:
> There is no kind of file does not supply page reading function.
> 
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@...wei.com>
> ---
>  fs/ext4/file.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index 8695f70..f5c0a17 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -202,8 +202,6 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma)
>  {
>  	struct address_space *mapping = file->f_mapping;

Assuming this change is correct, the 'mapping' variable is now unused and can
also be deleted.

> 
> -	if (!mapping->a_ops->readpage)
> -		return -ENOEXEC;
>  	file_accessed(file);
>  	vma->vm_ops = &ext4_file_vm_ops;
>  	return 0;