linux-ext4 - Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140705235542.GA19036@thunk.org>
Date:	Sat, 5 Jul 2014 19:55:42 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Gustavo Zacarias <gustavo@...arias.com.ar>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when
 cross-compiling

On Tue, Jun 03, 2014 at 06:51:59PM -0300, Gustavo Zacarias wrote:
> We need $INCLUDES in BUILD_CFLAGS otherwise cross-compilation is broken
> now that util/subst.c uses config.h (from commit 2873927d15).
> 
> Signed-off-by: Gustavo Zacarias <gustavo@...arias.com.ar>
> ---
>  configure.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.in b/configure.in
> index 448a292..8bac870 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -1382,7 +1382,7 @@ if test $cross_compiling = no; then
>     BUILD_CFLAGS="$CFLAGS $CPPFLAGS $INCLUDES -DHAVE_CONFIG_H"
>     BUILD_LDFLAGS="$LDFLAGS"
>  else
> -   BUILD_CFLAGS=
> +   BUILD_CFLAGS="$INCLUDES -DHAVE_CONFIG_H"

I would think that

BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H"

... would be safer, since $INCLUDES could potentially include some
$CPPFLAGS that could be specific to the target architecture.

Yes?

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html