linux-ext4 - Re: blkid: [v2] remove unnecessary header and comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140705033150.GA29001@thunk.org>
Date:	Fri, 4 Jul 2014 23:31:50 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: blkid: [v2] remove unnecessary header and comment

On Wed, Jun 11, 2014 at 12:59:05PM -0600, Andreas Dilger wrote:
> The LIST_HEAD macro is not directly used in getsize.c, so
> <sys/queue.h> is not needed at all, and could cause confusion at
> some later point if the Linux-style list macros are ever used.
> 
> Build was verified on MacOS which defined HAVE_SYS_DISK_H true.
> I manually inspected the sources for recent *BSD headers to check
> if this was needed there or not.  MacOS and FreeBSD <sys/disk.h>
> do not use lists at all.  NetBSD and OpenBSD <sys/disk.h> and all
> of the <sys/mount.h> headers include <sys/queue.h> internally.
> 
> I used http://fxr.watson.org/fxr/source/sys/mount.h?v={OSTYPE}
> as a reference, checking both old and new *BSD versions.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html