linux-ext4 - Re: [PATCH] ext4: fix potential null pointer dereference in ext4_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1407081259150.2180@localhost.localdomain>
Date:	Tue, 8 Jul 2014 13:00:09 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Namjae Jeon <namjae.jeon@...sung.com>
cc:	"Theodore Ts'o" <tytso@....edu>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	"'Dan Carpenter'" <dan.carpenter@...cle.com>,
	Ashish Sangwan <a.sangwan@...sung.com>
Subject: Re: [PATCH] ext4: fix potential null pointer dereference in
 ext4_free_inode

On Tue, 8 Jul 2014, Namjae Jeon wrote:

> Date: Tue, 08 Jul 2014 14:41:22 +0900
> From: Namjae Jeon <namjae.jeon@...sung.com>
> To: Theodore Ts'o <tytso@....edu>
> Cc: linux-ext4 <linux-ext4@...r.kernel.org>,
>     'Dan Carpenter' <dan.carpenter@...cle.com>,
>     Ashish Sangwan <a.sangwan@...sung.com>
> Subject: [PATCH] ext4: fix potential null pointer dereference in
>     ext4_free_inode
> 
> Fix potential null pointer dereferencing problem caused by e43bb4e612
> ("ext4: decrement free clusters/inodes counters when block group declared bad")
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>

Looks good.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> ---
>  fs/ext4/ialloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index a87455d..6bfe7eb 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -338,7 +338,7 @@ out:
>  			fatal = err;
>  	} else {
>  		ext4_error(sb, "bit already cleared for inode %lu", ino);
> -		if (!EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
> +		if (gdp && !EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
>  			int count;
>  			count = ext4_free_inodes_count(sb, gdp);
>  			percpu_counter_sub(&sbi->s_freeinodes_counter,
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html