linux-ext4 - Re: [PATCH 4/4 v2] lib: add EXT2_ prefix for SUPERBLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140710060025.GV4622@azat>
Date:	Thu, 10 Jul 2014 10:00:25 +0400
From:	Azat Khuzhin <a3at.mail@...il.com>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	darrick.wong@...cle.com, linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 4/4 v2] lib: add EXT2_ prefix for SUPERBLOCK_{OFFSET,SIZE}

On Wed, Jul 09, 2014 at 02:32:54PM -0600, Andreas Dilger wrote:
> 
> On Jul 9, 2014, at 2:08 PM, Azat Khuzhin <a3at.mail@...il.com> wrote:
> 
> > Since mostly all macros have this prefix, and to avoid potential name
> > clashes.
> > 
> > Proposed-by: Andreas Dilger <adilger@...ger.ca>
> > Signed-off-by: Azat Khuzhin <a3at.mail@...il.com>
> 
> You can add:
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> 
> If you are refreshing the whole series, it might make sense to move this
> first, instead of adding a bunch of SUPERBLOCK_{SIZE,OFFSET} uses, and
> then changing them to EXT2_SUPERBLOCK_{SIZE,OFFSET} in the next patch.
> Not a huge deal either way, just a suggestion.

Yeah, that's a good point, I will do this.
Thanks.

Cheers, Azat.


-- 
Respectfully
Azat Khuzhin
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html