linux-ext4 - Re: ext4: journal has aborted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140715083101.2c70e8f5@archvile>
Date:	Tue, 15 Jul 2014 08:31:01 +0200
From:	David Jander <david@...tonic.nl>
To:	Eric Whitney <enwlinux@...il.com>
Cc:	"Darrick J. Wong" <darrick.wong@...cle.com>,
	"Theodore Ts'o" <tytso@....edu>,
	Matteo Croce <technoboy85@...il.com>,
	Dmitry Monakhov <dmonakhov@...nvz.org>,
	linux-ext4@...r.kernel.org, Azat Khuzhin <a3at.mail@...il.com>
Subject: Re: ext4: journal has aborted


Dear Eric, Ted, ...

On Thu, 10 Jul 2014 20:45:08 -0400
Eric Whitney <enwlinux@...il.com> wrote:

> * Darrick J. Wong <darrick.wong@...cle.com>:
> > On Thu, Jul 10, 2014 at 06:32:45PM -0400, Theodore Ts'o wrote:
> > > To be clear, what you would need to do is to revert commit
> > > 007649375f6af242d5b1df2c15996949714303ba to prevent the fs corruption.
> > > Darrick's patch is one that tries to fix the problem addressed by that
> > > commit in a different fashion.
> > > 
> > > Quite frankly, reverting the commit, which is causing real damage, is
> > > far more impotrant to me right now than what to do in order allow
> > > CONFIG_EXT4FS_DEBUG to work (which is nice, but it's only something
> > > that file system developers need, and to be honest I can't remember
> > > the last time I've used said config option).  But if we know that
> > > Darrick's fix works, I'm willing to push that to Linus at the same
> > > time that I push a revert of 007649375f6af242d5b1df2c15996949714303ba
> > 
> > Reverting the 007649375... patch doesn't seem to create any obvious regressions
> > on my test box (though again, I was never able to reproduce it as consistently
> > as Eric W.).
> > 
> > Tossing in the [1] patch also fixes the crash when CONFIG_EXT4_DEBUG=y on
> > 3.16-rc4.  I'd say it's safe to send both to Linus and stable.
> > 
> > If anyone experiences problems that I'm not seeing, please yell loudly and
> > soon!
> > 
> 
> Reverting the suspect patch - 007649375f - on 3.16-rc3 and running on the
> Panda yielded 10 successive "successful" generic/068 failures (no block
> bitmap trouble on reboot).  So, it looks like that patch is all of it.
> 
> Running the same test scenario on Darrick's patch (CONFIG_EXT4FS_DEBUG =>
> CONFIG_EXT4_DEBUG) applied to 3.16-rc3 lead to exactly the same result.
> No panics, BUGS, or other misbehavior whether generic/068 completed 
> successfully or failed (and that test used here simply because it was
> convenient) and no trouble on boot, etc.

Thanks a lot to everyone for the excellent work hunting this down!
I can confirm that on 3.16-rc5 the problem is gone. At least after extensively
testing yesterday, I have not been unable to reproduce it. No ext4 error
messages and no filesystem corruption anymore!

Best regards,

-- 
David Jander
Protonic Holland.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html