linux-ext4 - Re: RHEL e2fsprogs-1.40.4-sb_feature_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53C9A060.6090403@redhat.com>
Date:	Fri, 18 Jul 2014 17:32:00 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: RHEL e2fsprogs-1.40.4-sb_feature_check_ignore.patch

On 7/18/14, 2:50 PM, Dilger, Andreas wrote:
> I was looking through the RHEL e2fsprogs.spec file and saw that you are
> still
> carrying the e2fsprogs-1.40.4-sb_feature_check_ignore.patch to avoid
> problems
> if the kernel sets xattrs on a new filesystem and doesn't copy this into
> the
> backup superblock.

Ugh, yeah, that's just been there forever, TBH, I forgot about it.
I'll actually have to refamiliarize myself with why it showed up years
ago!  :)

> It seems that mke2fs enables the xattr feature in the superblock by default
> for all filesystems (courtesy of misc/default_profile.c), and e2fsck
> doesn't
> drop COMPAT_EXT_XATTR even if the filesystem doesn't have xattrs, so most
> of
> the danger of not having this patch are behind us.
> 
> That said, it probably still makes sense to include this patch into the
> upstream e2fsprogs, unless there is some reason not to?  It looks pretty
> low risk.

Well, ISTR at the time I added it, it was a hacky workaround, rather than 
a proper fix.  I'll have to look at it again.

-eric
 
> Cheers, Andreas
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html