linux-ext4 - [PATCH 22/24] e2fsck: check return value of ext2fs_extent_fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140718225528.31374.87729.stgit@birch.djwong.org>
Date:	Fri, 18 Jul 2014 15:55:28 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	tytso@....edu, darrick.wong@...cle.com
Cc:	linux-ext4@...r.kernel.org
Subject: [PATCH 22/24] e2fsck: check return value of
 ext2fs_extent_fix_parents()

When fixing parent nodes in an extent tree, check the return value for
errors and bail out if problems happen.

Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
Fixes-Coverity-Bug: 1193379
---
 e2fsck/pass1.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
index 1895ee4..c52b141 100644
--- a/e2fsck/pass1.c
+++ b/e2fsck/pass1.c
@@ -2074,7 +2074,10 @@ fix_problem_now:
 					pctx->str = "ext2fs_extent_delete";
 					return;
 				}
-				ext2fs_extent_fix_parents(ehandle);
+				pctx->errcode = ext2fs_extent_fix_parents(ehandle);
+				if (pctx->errcode &&
+				    pctx->errcode != EXT2_ET_NO_CURRENT_NODE)
+					break;
 				pctx->errcode = ext2fs_extent_get(ehandle,
 								  EXT2_EXTENT_CURRENT,
 								  &extent);

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html