linux-ext4 - Re: [PATCH] e2fsck: free bh on csum verify error in do_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1407181104330.12453@localhost.localdomain>
Date:	Fri, 18 Jul 2014 11:04:45 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Eric Sandeen <sandeen@...hat.com>
cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsck: free bh on csum verify error in do_one_pass

On Thu, 17 Jul 2014, Eric Sandeen wrote:

> Date: Thu, 17 Jul 2014 16:11:59 -0500
> From: Eric Sandeen <sandeen@...hat.com>
> To: ext4 development <linux-ext4@...r.kernel.org>
> Subject: [PATCH] e2fsck: free bh on csum verify error in do_one_pass
> 
> Coverity (re-)spotted this; it was triaged as a false positive,
> but it seems pretty clear that the bh (which was just checked)
> isn't currently freed before the function exits.

Looks good.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks!
-Lukas


> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c
> index 54579c2..66d02b2 100644
> --- a/e2fsck/recovery.c
> +++ b/e2fsck/recovery.c
> @@ -523,6 +523,7 @@ static int do_one_pass(journal_t *journal,
>  			    !jbd2_descr_block_csum_verify(journal,
>  							  bh->b_data)) {
>  				err = -EIO;
> +				brelse(bh);
>  				goto failed;
>  			}
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html